Skip to content

feat: display legacy idp mappings in idp sync settings #14866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 27, 2024

Closes #14788

Screenshot 2024-09-27 at 2 34 23 PM

@@ -268,7 +292,7 @@ const IdpMappingTable: FC<IdpMappingTableProps> = ({
<Table>
<TableHead>
<TableRow>
<TableCell width="45%">Idp {type}</TableCell>
<TableCell width="45%">IdP {type}</TableCell>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@aslilac aslilac merged commit 894c758 into main Sep 27, 2024
27 checks passed
@aslilac aslilac deleted the lilac/legacy-idp branch September 27, 2024 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display legacy_group_name_mapping if they exist on IDP Sync page
2 participants