Skip to content

chore: consolidate ManageSettingsLayout code #14885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 3, 2024
Merged

chore: consolidate ManageSettingsLayout code #14885

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bf9ab32
typescript is so irritating sometimes
aslilac Sep 30, 2024
05d1e80
oh
aslilac Sep 30, 2024
602ffab
fmt
aslilac Sep 30, 2024
88bc231
Merge branch 'main' into lilac/anger
aslilac Oct 1, 2024
445b82e
yay
aslilac Oct 2, 2024
183c5db
Merge branch 'main' into lilac/anger
aslilac Oct 2, 2024
c8eaa77
oih
aslilac Oct 2, 2024
f4beba0
here
aslilac Oct 2, 2024
3af9601
fix route
aslilac Oct 2, 2024
16f6650
Merge branch 'main' into lilac/anger
aslilac Oct 3, 2024
932f829
:)
aslilac Oct 3, 2024
4288004
whoops
aslilac Oct 3, 2024
62b4575
mock the context
aslilac Oct 3, 2024
6581e8d
fix some stories
aslilac Oct 3, 2024
0719fbd
jerk
aslilac Oct 3, 2024
6fea1be
wow
aslilac Oct 3, 2024
fc7732c
そうそう
aslilac Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
here
  • Loading branch information
@aslilac
aslilac committed Oct 2, 2024
commit f4beba0536cd60b3a85f8714e58c46b2dfeced69
4 changes: 1 addition & 3 deletions site/src/modules/management/SidebarView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,7 @@ const DeploymentSettingsNavigation: FC<DeploymentSettingsNavigationProps> = ({
</SidebarNavSubItem>
)}
{permissions.viewAllUsers && (
<SidebarNavSubItem href={linkToUsers.slice(1)}>
Users
</SidebarNavSubItem>
<SidebarNavSubItem href="users">Users</SidebarNavSubItem>
)}
<SidebarNavSubItem href="notifications">
<Stack direction="row" alignItems="center" spacing={1}>
Expand Down
Loading