Skip to content

feat: add template description #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2022
Merged

feat: add template description #1489

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fec05fc
feat: add template description
coadler May 16, 2022
0bc518a
description < 128b
coadler May 16, 2022
40b4d4a
fixup! description < 128b
coadler May 16, 2022
fc2ad7b
fixup! description < 128b
coadler May 16, 2022
bde9117
fix js tests
coadler May 16, 2022
73186a7
optional template description on create
coadler May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
description < 128b
  • Loading branch information
@coadler
coadler committed May 16, 2022
commit 0bc518ae280c171029e82c04078ab4cf509d117a
1 change: 1 addition & 0 deletions coderd/audit/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ var AuditableResources = auditMap(map[any]map[string]Action{
"name": ActionTrack,
"provisioner": ActionTrack,
"active_version_id": ActionTrack,
"description": ActionTrack,
},
&database.TemplateVersion{}: {
"id": ActionTrack,
Expand Down
2 changes: 1 addition & 1 deletion coderd/database/migrations/000011_template_description.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ALTER TABLE templates ADD COLUMN description VARCHAR(8192) NOT NULL DEFAULT '';
ALTER TABLE templates ADD COLUMN description VARCHAR(128) NOT NULL DEFAULT '';
2 changes: 1 addition & 1 deletion codersdk/organizations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type CreateTemplateRequest struct {
Name string `json:"name" validate:"username,required"`
// Description is a description of what the template contains. It must be
// less than 8192 bytes.
Description string `json:"description" validate:"lt=8192"`
Description string `json:"description" validate:"lt=128"`

// VersionID is an in-progress or completed job to use as an initial version
// of the template.
Expand Down