feat: remove dark blue theme #14890
feat: remove dark blue theme #14890
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
the |
|
pardon our messy e2e test output. that line you're looking at is unrelated, the real error was: with no extra details. 🙃 I'm assuming it's a flake and just started a re-run. I'll be back in a bit to check on it and give you a review. |
There was a problem hiding this comment.
we'll also want to add a db migration that sets the theme of any users currently using the dark blue theme back to the default, otherwise they won't see anything selected on the appearance settings page.
it should just look like:
UPDATE users SET theme_preference = '' WHERE theme_preference = 'darkBlue';and the down migration can just be an empty file with a comment saying something like
-- Nothing to restoreYou can create the migration files by running...
./coderd/database/migrations/create_migration.sh remove-dark-blue-theme85c93a5 to
5f78f57
Compare
5f78f57 to
a9274ee
Compare
a9274ee to
f68e15e
Compare
saw this issue #14811, looks like an easy change
considered trying to modify the type exported from
UpdateUserAppearanceSettingsRequestintypesGenerated.tsto be"light" | "dark", but not super sure how to generate types from the Go codebase, so have left this as it is