Skip to content

docs: explain --rich-parameter-file format #14941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2024
Merged

docs: explain --rich-parameter-file format #14941

merged 3 commits into from
Oct 9, 2024

Conversation

joobisb
Copy link
Contributor

@joobisb joobisb commented Oct 3, 2024 •
edited by matifali
Loading

This PR closes #13839

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Oct 3, 2024
@matifali
Copy link
Member

matifali commented Oct 3, 2024

Hi, @joobisb, this is an autogenerated file, so you should make this change in the go code for the create command.

@joobisb
Copy link
Contributor Author

joobisb commented Oct 3, 2024

Hi, @joobisb, this is an autogenerated file, so you should make this change in the go code for the create command.

oops, sorry didn't know that. Thanks for clarifying, will make those changes

@matifali matifali requested a review from EdwardAngert October 3, 2024 08:27
@joobisb
Copy link
Contributor Author

joobisb commented Oct 3, 2024

Hi, @joobisb, this is an autogenerated file, so you should make this change in the go code for the create command.

oops, sorry didn't know that. Thanks for clarifying, will make those changes

fixed it

matifali
matifali approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. When the CI passes it is good to merge.

@joobisb
Copy link
Contributor Author

joobisb commented Oct 8, 2024

Thanks for the contribution. When the CI passes it is good to merge.

@matifali can we merge this?

@matifali matifali merged commit 26df33a into coder:main Oct 9, 2024
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@EdwardAngert EdwardAngert Awaiting requested review from EdwardAngert

Assignees

@joobisb joobisb

Labels
community Pull Requests and issues created by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI Docs: explain --rich-parameter-file format
2 participants
@joobisb @matifali