Skip to content

feat: include Coder service prefix on agents #14944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Oct 3, 2024

fixes #14715

Configures agents to use an address both in the Tailscale service prefix and the new Coder service prefix. Also modifies the Coordinator auth to allow the new prefix.

Updates coder/tailscale to include coder/tailscale#62 which fixes a bug around forwarding TCP connections to localhost. This functionality is tested in the modifications to TestAgent_Dial.

Copy link
Contributor Author

spikecurtis commented Oct 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review October 3, 2024 07:00
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix branch from 86531ca to cbf1981 Compare October 3, 2024 07:06
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix-agents branch from 1b0c0fd to 3997b36 Compare October 3, 2024 07:06
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix branch from cbf1981 to fda7376 Compare October 3, 2024 07:11
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix-agents branch from 3997b36 to aa7aa04 Compare October 3, 2024 07:11
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix branch from fda7376 to 77e7453 Compare October 3, 2024 11:33
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix-agents branch from aa7aa04 to 2b072fd Compare October 3, 2024 11:34
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix branch from 77e7453 to db8516e Compare October 3, 2024 11:36
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix-agents branch from 2b072fd to f0c18d6 Compare October 3, 2024 11:36
Copy link
Contributor Author

spikecurtis commented Oct 4, 2024

Merge activity

  • Oct 4, 2:03 AM EDT: @spikecurtis started a stack merge that includes this pull request via Graphite.
  • Oct 4, 2:06 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 4, 2:16 AM EDT: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis changed the base branch from spike/coder-service-prefix to graphite-base/14944 October 4, 2024 06:04
@spikecurtis spikecurtis changed the base branch from graphite-base/14944 to main October 4, 2024 06:04
@spikecurtis spikecurtis force-pushed the spike/coder-service-prefix-agents branch from f0c18d6 to 4f9048e Compare October 4, 2024 06:05
@spikecurtis spikecurtis merged commit 8785a51 into main Oct 4, 2024
27 checks passed
@spikecurtis spikecurtis deleted the spike/coder-service-prefix-agents branch October 4, 2024 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Agent support for the new IPv6 prefix: fd60:627a:a42b::/48
3 participants