Skip to content

chore: storybook additions and cleanup #14968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

chore: storybook additions and cleanup #14968

merged 2 commits into from
Oct 4, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenh jaaydenh commented Oct 3, 2024

No description provided.

@jaaydenh jaaydenh self-assigned this Oct 3, 2024
@jaaydenh jaaydenh requested a review from aslilac October 3, 2024 20:23
aslilac
aslilac approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit. as long as all the new tests pass, looks great!

@jaaydenh jaaydenh merged commit ea3b13c into main Oct 4, 2024
27 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/storybook-roles-idp branch October 4, 2024 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaaydenh @aslilac