docs: provide example regexes to properly escape . characters #14983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matifali added you as a reviewer so you'll have the context for the zendesk ticket on Monday. |
|
Do Not Merge until after docs restructure 🙏 |
matifali
reviewed
Oct 7, 2024
matifali
approved these changes
Oct 7, 2024
|
@bcpeinhardt do you still want to merge this? |
|
Yes! It was failing CI before and I didn't have a chance to diagnose it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the example regular expressions we provide in the docs for managing coder external auth don't escape
.characters correctly. This PR simply corrects that.