Skip to content

fix: Allow setting STUN to an empty string #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

fix: Allow setting STUN to an empty string #1502

merged 1 commit into from
May 17, 2022

Conversation

kylecarbs
Copy link
Member

This allows users to entirely disable STUN.

@kylecarbs kylecarbs self-assigned this May 17, 2022
@kylecarbs
fix: Allow setting STUN to an empty string
bac89ec 
This allows users to entirely disable STUN.
@kylecarbs kylecarbs requested a review from coadler May 17, 2022 03:31
@kylecarbs kylecarbs enabled auto-merge (squash) May 17, 2022 03:31
@kylecarbs kylecarbs requested a review from deansheather May 17, 2022 14:05
@kylecarbs kylecarbs merged commit fc9efc2 into main May 17, 2022
@kylecarbs kylecarbs deleted the disablestun branch May 17, 2022 14:12
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Allow setting STUN to an empty string (#1502)
1ebc2df 
This allows users to entirely disable STUN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @deansheather