Skip to content

chore(cli): rename build options to ephemeral parameters in cli #15030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 16, 2024
Merged

chore(cli): rename build options to ephemeral parameters in cli #15030

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fa3b28f
chore: rename build options to ephemeral parameters in cli
defelmnq Oct 9, 2024
fbf1c50
fix: generate golden files
defelmnq Oct 9, 2024
ab0fe51
gen: cli docs
defelmnq Oct 9, 2024
6986958
fix: remove hidden tag to build-option
defelmnq Oct 9, 2024
7b1b9af
fix: remove hidden tag to build-option
defelmnq Oct 9, 2024
c91ffbe
Merge branch 'main' into chore/rename-build-option-to-ephemeral-param
defelmnq Oct 10, 2024
06b6c09
doc(build-parameters): work on wording around ephemeral parameters
defelmnq Oct 10, 2024
3b2bb1f
Merge remote-tracking branch 'origin/chore/rename-build-option-to-eph…
defelmnq Oct 10, 2024
4313b7e
Update cli/parameter.go
defelmnq Oct 13, 2024
b2aea6c
Update cli/parameter.go
defelmnq Oct 13, 2024
19f0bae
make fmt
EdwardAngert Oct 14, 2024
d4838d8
Merge remote-tracking branch 'origin' into chore/rename-build-option-…
EdwardAngert Oct 14, 2024
4d069b7
fix links
EdwardAngert Oct 14, 2024
33b0313
fix link
EdwardAngert Oct 14, 2024
559bb22
Merge remote-tracking branch 'origin/main' into chore/rename-build-op…
defelmnq Oct 16, 2024
905a683
fix(doc): generate docs with new parameters
Oct 16, 2024
6b138a6
fix(doc): generate docs with new parameters
Oct 16, 2024
5e11687
feat(cli): add back test on deprecated flags build-option and build-o…
defelmnq Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update cli/parameter.go 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
  • Loading branch information
@defelmnq @mafredri
defelmnq and mafredri authored Oct 13, 2024
commit 4313b7e5254c00116644e723773e11fbc725b2d0
2 changes: 1 addition & 1 deletion cli/parameter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (wpf *workspaceParameterFlags) cliEphemeralParameters() []serpent.Option {
{
Flag: "prompt-ephemeral-parameters",
Env: "CODER_PROMPT_EPHEMERAL_PARAMETERS",
Description: "Prompt for values of ephemeral parameters described in the template.",
Description: "Prompt to set values of ephemeral parameters defined in the template. If a value has been set via --ephemeral-parameter, it will not be prompted for.",
Value: serpent.BoolOf(&wpf.promptEphemeralParameters),
},
}
Expand Down
Loading