Skip to content

feat(cli): extend duration to longer units #15040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 16, 2024
Merged

feat(cli): extend duration to longer units #15040

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
93e2e47
feat(cli): extend duration to longer units
defelmnq Oct 10, 2024
617fda1
feat(cli): call codersk to get default token lifetime
defelmnq Oct 10, 2024
6ce2600
fix: golden files and docs
defelmnq Oct 10, 2024
950c056
feat(cli): extend duration to longer units
defelmnq Oct 14, 2024
e294630
Merge remote-tracking branch 'origin/feat/improve-duration-flags' int…
defelmnq Oct 14, 2024
02cfb2b
feat(cli): improve long duration testing and negative values
defelmnq Oct 14, 2024
c51cf20
feat(cli): improve long duration testing and negative values
defelmnq Oct 14, 2024
256c085
feat(cli): improve long duration testing and negative values
defelmnq Oct 14, 2024
12e2c2d
feat(cli): improve long duration testing and negative values
defelmnq Oct 14, 2024
7723ae9
Merge remote-tracking branch 'origin/main' into feat/improve-duration…
defelmnq Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(cli): improve long duration testing and negative values
  • Loading branch information
@defelmnq
defelmnq committed Oct 14, 2024
commit 256c085b9df7ac5ed14fa573c3afe8c6ba01c6e6
4 changes: 2 additions & 2 deletions cli/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ func isDigit(s string) bool {
// extendedParseDuration is a more lenient version of parseDuration that allows
// for more flexible input formats and cumulative durations.
// It allows for some extra units:
// - d (days)
// - y (years)
// - d (days, interpreted as 24h)
// - y (years, interpreted as 8_760h)
//
// FIXME: handle fractional values as discussed in https://github.com/coder/coder/pull/15040#discussion_r1799261736
func extendedParseDuration(raw string) (time.Duration, error) {
Expand Down
Loading