feat: use hashicorp/cloud-init provider in AWS devcontainer template
#15050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp/cloud-initprovider in AWS templates
hashicorp/cloud-initprovider in AWS templateshashicorp/cloud-init provider in AWS templates
hashicorp/cloud-init provider in AWS templateshashicorp/cloud-init provider in AWS devcontainer template
johnstcn
approved these changes
Oct 14, 2024
examples/templates/aws-devcontainer/cloud-init/userdata.sh.tftpl
Outdated
Show resolved
Hide resolved
|
@phorcys420, if it is ready, you can merge. Or are you planning to include other examples in the same PR? |
|
hey @matifali -- I just need to remove a comment and rebase then it's good! |
3e92337 to
e080131
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes templates uses the hashicorp/cloud-init provider instead of hardcoding a cloud-init config.
This makes for more readable/maintainable templates.
I tested this template on dev.coder.com and it works as expected.
see https://dev.coder.com/templates/coder/aws-devcontainer-cloudinit-test
Left to do:
cc: @johnstcn