feat: allow promoting an existing template version to active from CLI #15051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Oct 14, 2024
cli/templateversions.go
Outdated
| ) | ||
| client := new(codersdk.Client) | ||
| cmd := &serpent.Command{ | ||
| Use: "promote", |
There was a problem hiding this comment.
I don't think there is precedence for required flags, can we add to the Use to include the required flags?
Suggested change
| Use: "promote", | |
| Use: "promote --template=<template_name> --template-version=<template_version_name>", |
We include required params in other Use fields:
Line 18 in 61c37d0
Emyrk
reviewed
Oct 14, 2024
| coder v0.0.0-devel | ||
|
|
||
| USAGE: | ||
| coder templates versions promote [flags] |
There was a problem hiding this comment.
I know the output [flags] technically includes my usage comment earlier. Given they are required, I wonder if we should include them more explicitly.
|
@Emyrk I've addressed the comments, please do have a look |
Emyrk
approved these changes
Oct 15, 2024
|
@Emyrk I think CI failure is unrelated, can we merge this? |
|
It was, thanks @matifali 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #15042