-
Notifications
You must be signed in to change notification settings - Fork 881
fix: example: update docker-local to use host-gateway #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very smooth!
Not necessarily in this PR, but I think we still want to document the setup steps?
cd /path/to/coder/repo
docker-compose up -d
coder login http://localhost:7080 # Create first user
coder templates create -d ./examples/docker-local
coder create dev
We could try to make some of them part of the compose file, perhaps it'd also be nicer to docker-compose run coder login ...
to avoid having to install the binary.
…CONNECTION_URL Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
docker-compose.yaml
Outdated
CODER_ADDRESS: "0.0.0.0:7080" | ||
CODER_ACCESS_URL: "http://host.docker.internal:7080" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be set inside the specific template!
Override the "url" field of the "coder" provider!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
I didn't realize we had a docker-compose. Sweet! |
@mafredri Yep, I'd like to document it, but I'd consider #1528 another blocker from this being a clean workflow. I'm not really sure what the best way to document the |
* fix: example: update docker-local to use host-gateway * docker-compose.yaml: Add POSTGRES_ environment variables to CODER_PG_CONNECTION_URL Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
This PR attempts to reduce the friction to getting a workspace up and running in docker when running Coder via
docker-compose
using the exampledocker-local
template:docker-compose.yaml
: pass through docker socket and set CODER_ACCESS_URL envexamples/docker-local
: add host.docker.internal to containersSee: #1345