Skip to content

test: skip scaletest/reconnectingpty Test_Runner #15076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

test: skip scaletest/reconnectingpty Test_Runner #15076

merged 1 commit into from
Oct 15, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Oct 15, 2024

@mtojek mtojek added the hotfix label Oct 15, 2024
@mtojek mtojek self-assigned this Oct 15, 2024
@mtojek mtojek marked this pull request as ready for review October 15, 2024 12:16
cdr-bot[bot]
cdr-bot bot approved these changes Oct 15, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

mtojek
mtojek commented Oct 15, 2024
View reviewed changes
scaletest/createworkspaces/run_test.go
@@ -31,7 +31,6 @@ import (

func Test_Runner(t *testing.T) {
t.Parallel()
t.Skip("https://github.com/coder/internal/issues/98")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong test

@mtojek mtojek enabled auto-merge (squash) October 15, 2024 12:19
@mtojek mtojek merged commit 1523d93 into main Oct 15, 2024
30 checks passed
@mtojek mtojek deleted the 98-skip-3 branch October 15, 2024 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtojek