fix: correct connection_median_latency_ms in query #15086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0ssel
commented
Oct 16, 2024
| @@ -661,7 +661,7 @@ WITH | |||
| AND date_trunc('minute', was.created_at) = mb.minute_bucket | |||
| AND was.template_id = mb.template_id | |||
| AND was.user_id = mb.user_id | |||
| AND was.connection_median_latency_ms >= 0 | |||
There was a problem hiding this comment.
This is the bug fix, in other queries that use connection_median_latency_ms we always filter our the 0 values to rule out any usage stats.
f0ssel
commented
Oct 16, 2024
Comment on lines
+339
to
+340
| -- The greater than 0 is to support legacy agents that don't report connection_median_latency_ms. | ||
| WHERE workspace_agent_stats.created_at > $1 AND connection_median_latency_ms > 0 |
There was a problem hiding this comment.
This is another fix I found along the way where we weren't filtering out the stats with 0 or selecting only recent stats.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14805