feat: Add templates page #1510
Merged
feat: Add templates page #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15637bd to
6e2e734
Compare
greyscaled
reviewed
May 17, 2022
| </div> | ||
| </TableCell> | ||
| </TableRow> | ||
| )} |
There was a problem hiding this comment.
Should there be an associated spinner view when loading is true? In the Storybook right now, toggling loading doesn't change anything:
greyscaled
reviewed
May 17, 2022
greyscaled
reviewed
May 17, 2022
Comment on lines
+46
to
+48
| <TableCell>Name</TableCell> | ||
| <TableCell>Used By</TableCell> | ||
| <TableCell>Last Updated</TableCell> |
There was a problem hiding this comment.
Suggestion: Language for these as well
There was a problem hiding this comment.
I'm happy to add it, but I'm curious why do it for small labels like this? Seems like it's most valuable for testing, and I don't think we'd want to test that each column appears.
greyscaled
reviewed
May 17, 2022
BrunoQuaresma
approved these changes
May 18, 2022
Kira-Pilot
reviewed
May 18, 2022
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
* feat: Add template page * Create xService * Update column names * Show create template conditionally * Add template description * Route to templates * Add empty states * Add tests * Add loading indicator * Requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the states are added in Storybook, so feel free to poke around and provide feedback!
This is pretty basic for now, but I'm thinking we should add a little resource preview column that displays operating systems and architectures 🤓