Skip to content

test: improve logging around TestAgentScript #15121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

test: improve logging around TestAgentScript #15121

merged 1 commit into from
Oct 17, 2024

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Oct 17, 2024

Spotted in: https://github.com/coder/coder/actions/runs/11372981036/job/31638824818

This PR modifies provisionersdk TestAgentScript to present command logs if the process exits without any notice.

=== FAIL: provisionersdk TestAgentScript/Invalid (10.00s)
    agent_test.go:126: 
        	Error Trace:	/Users/runner/work/coder/coder/provisionersdk/agent_test.go:126
        	Error:      	Received unexpected error:
        	            	os: process already finished
        	Test:       	TestAgentScript/Invalid

@mtojek mtojek self-assigned this Oct 17, 2024
@mtojek mtojek added the hotfix label Oct 17, 2024
@mtojek mtojek marked this pull request as ready for review October 17, 2024 11:06
cdr-bot[bot]
cdr-bot bot approved these changes Oct 17, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@mtojek mtojek merged commit bab17a3 into main Oct 17, 2024
30 checks passed
@mtojek mtojek deleted the provisionersdk-agent-debug branch October 17, 2024 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtojek