feat(helm): add topologySpreadConstraints value #15168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
Oct 22, 2024
6ba6105 to
e744e17
Compare
johnstcn
reviewed
Oct 24, 2024
| @@ -236,6 +236,14 @@ coder: | |||
| topologyKey: kubernetes.io/hostname | |||
| weight: 1 | |||
|
|
|||
| topologySpreadConstraints: | |||
There was a problem hiding this comment.
Suggested change
| topologySpreadConstraints: | |
| # coder.topologySpreadConstraints -- Topology spread constraints. | |
| # See: https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ | |
| topologySpreadConstraints: |
spikecurtis
approved these changes
Oct 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my attempt at closing #12904 - @spikecurtis let me know where i'm going wrong, the
topologySpreadConstraintsvalue is not included in the template despite being set in thevalues.yaml.i'm running
helm template . --debugto test.