fix(helm/coder): set serviceAccount.disableCreate=false by default, add tests #15197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're here, might be worth adding |
1ae4ce6 to
19a429d
Compare
johnstcn
commented
Oct 23, 2024
| @@ -90,6 +90,7 @@ jobs: | |||
| - "coderd/**" | |||
| - "enterprise/**" | |||
| - "examples/*" | |||
| - "helm/**" | |||
There was a problem hiding this comment.
@ethanndickson does that look right to you?
This reverts commit 19a429d.
ericpaulsen
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serviceaccount.disableCreate=falseby default (accidentally changed by feat(helm): add setting to disable service account creation #14817)