Skip to content

chore(provisioner/terraform): extract terraform parsing logic to package tfparse #15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Oct 25, 2024

Related to #15087

This PR extracts the logic for extracting variables and workspace tags to a separate package tfextract tfparse.

This does not modify any existing logic, but keeps the existing tests in the same location.
A future PR will add more functionality + tests to this package.

@johnstcn johnstcn self-assigned this Oct 25, 2024
@johnstcn johnstcn changed the title chore(provisioner/terraform): extract terraform parsing logic to package tfextract chore(provisioner/terraform): extract terraform parsing logic to package tfparse Oct 25, 2024
Copy link
Contributor

@DanielleMaywood DanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with one stylistic issue

Co-authored-by: Danielle Maywood <danielle@themaywoods.com>
@johnstcn johnstcn merged commit 5ad4747 into main Oct 25, 2024
26 checks passed
@johnstcn johnstcn deleted the cj/extract-pkg-tfextract branch October 25, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants