chore: tweak e2e test timeouts #15275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a particular reason this is still in Draft? Looks good to me as a short term tweak. Drive by comment only vaguely related to this PR (non-blocking): I think we should be treating timeouts as first class test criteria as opposed something we tweak to handle flakes. That said, I'm aware the test execution environment makes all the difference. |
bcpeinhardt
reviewed
Oct 29, 2024
|
because I forgor to hit "ready" lol |
bcpeinhardt
approved these changes
Oct 30, 2024
|
Another time-out: https://github.com/coder/coder/actions/runs/11591672727/job/32271926364 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#178
tweak some timeouts for slow tests/operations to be more targeted, so that we can make the generic timeout shorter and reduce the number of flakes caused by timeouts on the long running/slow tests.