Skip to content

fix(coderd/provisionerdserver): prevent NPE if no user link exists #15289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix(coderd/provisionerdserver): prevent NPE if no user link exists #15289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54beb67
fix(provisionerdserver): prevent NPE if no user link exists
johnstcn Oct 30, 2024
c1d3874
fixup! fix(provisionerdserver): prevent NPE if no user link exists
johnstcn Oct 30, 2024
50cf7b4
add test
johnstcn Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fix(provisionerdserver): prevent NPE if no user link exists
  • Loading branch information
@johnstcn
johnstcn committed Oct 30, 2024
commit c1d387429e11f41475767dfb64874f9ce4c5f971
2 changes: 1 addition & 1 deletion coderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2026,7 +2026,7 @@ func obtainOIDCAccessToken(ctx context.Context, db database.Store, oidcConfig pr
LoginType: database.LoginTypeOIDC,
})
if errors.Is(err, sql.ErrNoRows) {
return nil, nil //nolint:nilnil
return "", nil
}
if err != nil {
return "", xerrors.Errorf("get owner oidc link: %w", err)
Expand Down
Loading