Skip to content

refactor(site): refactor DAU chart to avoid seat consumption focus #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

Related to https://github.com/coder/coder/issues/15297

  • Clearly display this as Daily Active Users
  • Remove the user limit bar at the top for licensed deployments
  • Explain in the tooltip that this is for measuring user activity and has no connection to license consumption

@BrunoQuaresma BrunoQuaresma requested review from matifali, bpmct and a team October 31, 2024 14:54
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 31, 2024
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team October 31, 2024 14:54
Comment on lines 128 to 133
<HelpTooltipText>
When a connection is initiated to a user&apos;s workspace they are
considered an active user. e.g. apps, web terminal, SSH
considered an active user. e.g. apps, web terminal, SSH. This is for
measuring user activity and has no connection to license
consumption.
</HelpTooltipText>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with the new messaging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@BrunoQuaresma BrunoQuaresma added the hotfix PRs only. Harmless small change. Only humans may set this. label Oct 31, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma BrunoQuaresma merged commit 4849b4d into main Oct 31, 2024
31 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-dau branch October 31, 2024 15:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@matifali
Copy link
Member

@stirby, do you want to pick this into the release/2.17 branch?

@stirby
Copy link
Collaborator

stirby commented Nov 1, 2024

Done @matifali.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants