feat: Add timeline in the workspace page #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
May 17, 2022
| <span style={{ color: theme.palette.text.secondary }}>{duration}</span> | ||
| </TableCell> | ||
| <TableCell> | ||
| <span style={{ color: theme.palette.text.secondary }}>{new Date(b.created_at).toLocaleString()}</span> |
There was a problem hiding this comment.
I used toLocaleString() because it is better to have, for logs at least, the format 5/17/2022, 2:06:25 PM instead of 50 seconds ago.
BrunoQuaresma
commented
May 17, 2022
| @@ -47,3 +48,71 @@ export const getWorkspaceStatus = (workspaceBuild?: WorkspaceBuild): WorkspaceSt | |||
| return "error" | |||
| } | |||
| } | |||
|
|
|||
| export const getDisplayStatus = ( | |||
There was a problem hiding this comment.
- Moved this to
utils/workspacesso I could use it in the Timeline component. - I see we also have another
getStatusfunction so I moved this with a new name. Probably we want to use only one, but I think it is better to make this on the design refactoring.
BrunoQuaresma
commented
May 17, 2022
| @@ -29,6 +41,8 @@ export type WorkspaceEvent = | |||
| | { type: "STOP" } | |||
| | { type: "RETRY" } | |||
| | { type: "UPDATE" } | |||
| | { type: "LOAD_MORE_BUILDS" } | |||
There was a problem hiding this comment.
I will implement this when the BE is done
BrunoQuaresma
commented
May 17, 2022
| throw Error("Cannot refresh workspace without id") | ||
| } | ||
| }, | ||
| loadMoreBuilds: async (context) => { |
There was a problem hiding this comment.
It will change when the BE is ready.
kylecarbs
approved these changes
May 18, 2022
| states: { | ||
| idle: { | ||
| on: { | ||
| LOAD_MORE_BUILDS: { |
There was a problem hiding this comment.
Yeap! To load more/old builds.
presleyp
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.