Skip to content

chore: refactor tailnetAPIConnector to use dialer #15347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: refactor tailnetAPIConnector to use dialer #15347

merged 1 commit into from
Nov 7, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Nov 4, 2024 •
edited
Loading

refactors tailnetAPIConnector to use the Dialer interface in tailnet, introduced lower in this stack of PRs. This will let us use the same Tailnet API handling code across different things that connect to the Tailnet API (CLI client, coderd, workspace proxies, and soon: Coder VPN).

chore re: #14729

This was referenced Nov 4, 2024
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis mentioned this pull request Nov 4, 2024
Merged
@spikecurtis spikecurtis marked this pull request as ready for review November 4, 2024 05:41
@spikecurtis spikecurtis force-pushed the spike/14729-resume-token-controller branch from 5c3b3a4 to af61bca Compare November 4, 2024 05:47
@spikecurtis spikecurtis mentioned this pull request Nov 4, 2024
Merged
sreya
sreya approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits LGTM

@spikecurtis spikecurtis force-pushed the spike/14729-resume-token-controller branch from af61bca to 4f79cf7 Compare November 5, 2024 09:51
@spikecurtis spikecurtis force-pushed the spike/14729-resume-token-controller branch from 4f79cf7 to 5552b4f Compare November 5, 2024 10:02
@spikecurtis spikecurtis force-pushed the spike/14729-resume-token-controller branch from 5552b4f to 2180c3f Compare November 6, 2024 13:13
This was referenced Nov 6, 2024
Merged
Merged
@spikecurtis spikecurtis force-pushed the spike/14729-resume-token-controller branch from 2180c3f to 82852ad Compare November 6, 2024 16:05
@spikecurtis spikecurtis force-pushed the spike/14729-resume-token-controller branch 2 times, most recently from e702cb7 to 49baee8 Compare November 6, 2024 16:24
@spikecurtis spikecurtis changed the base branch from spike/14729-resume-token-controller to graphite-base/15347 November 7, 2024 07:32
@spikecurtis spikecurtis changed the base branch from graphite-base/15347 to main November 7, 2024 07:33
@spikecurtis spikecurtis merged commit 2d061e6 into main Nov 7, 2024
27 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Nov 7, 8:24 AM EST: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/14729-dialer branch November 7, 2024 13:24
jaaydenh pushed a commit that referenced this pull request Nov 8, 2024
@spikecurtis @jaaydenh
chore: refactor tailnetAPIConnector to use dialer (#15347)
91054ef 
refactors `tailnetAPIConnector` to use the `Dialer` interface in `tailnet`, introduced lower in this stack of PRs. This will let us use the same Tailnet API handling code across different things that connect to the Tailnet API (CLI client, coderd, workspace proxies, and soon: Coder VPN).

chore re: #14729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreya sreya sreya approved these changes

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spikecurtis @sreya @ethanndickson