Skip to content

chore: update workflow permissions #15349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: update workflow permissions #15349

merged 1 commit into from
Nov 4, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Nov 4, 2024

continuation of #15282

@matifali
chore: update permissions in ci.yaml
9ab7e54 
Signed-off-by: Muhammad Atif Ali <me@matifali.dev>
@matifali matifali changed the title chore: update permissions in ci.yaml chore: update workflow permissions Nov 4, 2024
@matifali matifali added the hotfix PRs only. Harmless small change. Only humans may set this. label Nov 4, 2024
cdr-bot[bot]
cdr-bot bot approved these changes Nov 4, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali merged commit 3a5a42f into main Nov 4, 2024
36 checks passed
@matifali matifali deleted the atif/update-workflow-permissions branch November 4, 2024 06:09
@ethanndickson ethanndickson mentioned this pull request Dec 11, 2024
Merged
ethanndickson added a commit that referenced this pull request Dec 11, 2024
@ethanndickson
fix: give cla workflow pull request write permissions (#15820)
ea9e39d 
When #15349 was added, it implicitly
set all the other permissions to none.

From
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token
> If you specify the access for any of these permissions, all of those
that are not specified are set to none.
aslilac pushed a commit that referenced this pull request Dec 11, 2024
@ethanndickson @aslilac
fix: give cla workflow pull request write permissions (#15820)
566e07b 
When #15349 was added, it implicitly
set all the other permissions to none.

From
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token
> If you specify the access for any of these permissions, all of those
that are not specified are set to none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@matifali matifali

Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matifali