Skip to content

chore: refactor tailnetAPIConnector to tailnet.Controller #15361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore: refactor tailnetAPIConnector to tailnet.Controller #15361

merged 1 commit into from
Nov 8, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Nov 4, 2024 •
edited
Loading

Refactors workspacesdk.tailnetAPIConnector as a tailnet.Controller to reuse all the reconnection and graceful disconnect logic.

chore re: #14729

This was referenced Nov 4, 2024
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Nov 4, 2024
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review November 4, 2024 08:15
ethanndickson
ethanndickson approved these changes Nov 5, 2024
View reviewed changes
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from eadc0d2 to 915ab6b Compare November 5, 2024 09:53
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from 915ab6b to a8a598f Compare November 5, 2024 10:02
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from a8a598f to c6c3f05 Compare November 6, 2024 13:14
This was referenced Nov 6, 2024
Merged
Merged
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from c6c3f05 to e3f80df Compare November 6, 2024 16:06
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from e3f80df to 791e183 Compare November 6, 2024 16:25
@spikecurtis spikecurtis force-pushed the spike/14729-dialer branch 2 times, most recently from 7f474ec to d6b2a1a Compare November 7, 2024 07:33
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from 791e183 to c79d83d Compare November 7, 2024 07:33
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from c79d83d to e6e3c8f Compare November 7, 2024 13:10
@spikecurtis spikecurtis changed the base branch from spike/14729-dialer to graphite-base/15361 November 7, 2024 13:24
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from e6e3c8f to bf47e04 Compare November 7, 2024 13:24
@spikecurtis spikecurtis changed the base branch from graphite-base/15361 to main November 7, 2024 13:25
@spikecurtis spikecurtis force-pushed the spike/14729-controller branch from bf47e04 to abd4edd Compare November 7, 2024 13:25
@spikecurtis spikecurtis merged commit 718722a into main Nov 8, 2024
27 checks passed
@spikecurtis spikecurtis deleted the spike/14729-controller branch November 8, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @ethanndickson