Add terminal link component #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `workspace.agent` syntax was only used when fetching the agent and not the workspace so it would try to fetch a workspace called `workspace.agent` instead of just `workspace`.
Currently it does not show anywhere but we can drop it into the resources card later.
greyscaled
approved these changes
May 18, 2022
presleyp
approved these changes
May 18, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Fix not being able to specify agent when connecting to terminal The `workspace.agent` syntax was only used when fetching the agent and not the workspace so it would try to fetch a workspace called `workspace.agent` instead of just `workspace`. * Add terminal link component Currently it does not show anywhere but we can drop it into the resources card later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if the component is overkill or not but if so maybe we can pull it out once the resource card is ready? But I could see it being used in multiple places. I did not do anything with the styling so it is just a plain link right now.
Partially addresses #760 (we just need to drop it into the resources card once it is good to go).
Other than that the terminal already supported connecting to a specific workspace agent using a
workspaceName.agentNamesyntax so all I had to do was fix a small bug with it (it only split it when fetching the agent and not when fetching the workspace so the workspace fetch would error; I just moved this logic out so it would apply to both calls).