Skip to content

chore(site): fix reset password storybook flake #15380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma requested a review from a team November 5, 2024 13:44
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 5, 2024
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team November 5, 2024 13:44
@code-asher
Copy link
Member

This seems reasonable to me, but would it be better to ignore the element instead, if Chromatic can do that?

@BrunoQuaresma
Copy link
Collaborator Author

We want to validate the style, so I will leave it there for now.

@BrunoQuaresma BrunoQuaresma merged commit 18c2386 into main Nov 6, 2024
28 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-storybook-flake-reset-password branch November 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flake: Storybook test for User Reset Password
2 participants