Skip to content

docs: disable markdown link check on mailto links #15382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

EdwardAngert
Copy link
Contributor

to satisfy CI

@EdwardAngert EdwardAngert added docs Area: coder.com/docs hotfix labels Nov 5, 2024
@EdwardAngert EdwardAngert self-assigned this Nov 5, 2024
cdr-bot[bot]
cdr-bot bot previously approved these changes Nov 5, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main or release branch
  • ❌ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@cdr-bot cdr-bot bot dismissed their stale review November 5, 2024 16:27

This PR is no longer a hotfix.

@EdwardAngert EdwardAngert changed the title docs(fix): disable markdown link check on mailto links docs: disable markdown link check on mailto links Nov 5, 2024
@matifali
Copy link
Member

matifali commented Nov 5, 2024

You can also add an exception to https://github.com/coder/coder/blob/2024-11-05-linkfix/.github/workflows/mlc_config.json for mailto: links

@EdwardAngert
Copy link
Contributor Author

You can also add an exception to https://github.com/coder/coder/blob/2024-11-05-linkfix/.github/workflows/mlc_config.json for mailto: links

thanks, @matifali ! I'll try that - it looks like it's supposed to validate emails , but I'm down to just skip that with an ignore pattern

@EdwardAngert EdwardAngert merged commit 62fa7e5 into main Nov 5, 2024
24 checks passed
@EdwardAngert EdwardAngert deleted the 2024-11-05-linkfix branch November 5, 2024 17:35
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jaaydenh pushed a commit that referenced this pull request Nov 5, 2024
to satisfy CI

---------

Co-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants