test: Using local time in unit test fails in certain time zones #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing when running in CST (GMT-5) timezone. My local timezone pushed the next to the upcoming monday
kylecarbs
approved these changes
May 18, 2022
|
@Emyrk I went ahead and also added a commit that fixes the test semantics properly. |
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* test: Using local time in unit test fails in certain time zones This test was failing when running in CST (GMT-5) timezone. My local timezone pushed the next to the upcoming monday * fix: schedule: assert expected result of String() separately from input spec Co-authored-by: Cian Johnston <cian@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing when running in CST (GMT-5) timezone.
My local timezone pushed the next to the upcoming monday
@johnstcn Is this change to the test ok? I was not really sure what it was testing. The CI says "Without timezone", but the spec does include the timezone as UTC.