Skip to content

feat: add support for multiple tunnel destinations in tailnet #15409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: add support for multiple tunnel destinations in tailnet #15409

merged 1 commit into from
Nov 8, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Nov 6, 2024 •
edited
Loading

Closes #14729

Expands the Coordination controller used by the CLI client to allow multiple tunnel destinations (agents). Our current client uses just one, but this unifies the logic so that when we add Coder VPN, 1 is just a special case of "many."

This was referenced Nov 6, 2024
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Nov 6, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Nov 6, 2024
Merged
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review November 6, 2024 13:18
@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch from cb664c3 to 8993828 Compare November 6, 2024 16:06
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from d3a937d to 2bc1218 Compare November 6, 2024 16:07
@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch from 8993828 to ed2ba52 Compare November 6, 2024 16:25
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from 2bc1218 to a82e73a Compare November 6, 2024 16:26
ethanndickson
ethanndickson approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these tests, easy to follow.
LGTM 👏

@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch from ed2ba52 to d9b0988 Compare November 7, 2024 07:33
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from a82e73a to 5fe6c15 Compare November 7, 2024 07:34
@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch from d9b0988 to b8062ab Compare November 7, 2024 13:10
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from 5fe6c15 to 28d24aa Compare November 7, 2024 13:10
@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch from b8062ab to 845efd2 Compare November 7, 2024 13:25
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from 28d24aa to 173a166 Compare November 7, 2024 13:25
@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch 2 times, most recently from b8ed4ea to 2603e6d Compare November 8, 2024 06:11
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from 173a166 to 5b58b35 Compare November 8, 2024 06:11
@spikecurtis spikecurtis force-pushed the spike/14729-server-tailnet branch from 2603e6d to 778457b Compare November 8, 2024 09:05
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from 5b58b35 to f318880 Compare November 8, 2024 09:05
@spikecurtis spikecurtis changed the base branch from spike/14729-server-tailnet to graphite-base/15409 November 8, 2024 09:18
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from f318880 to ce65647 Compare November 8, 2024 09:19
@spikecurtis spikecurtis changed the base branch from graphite-base/15409 to main November 8, 2024 09:19
@spikecurtis spikecurtis force-pushed the spike/14729-tunnel-src-ctrl branch from ce65647 to 44fd538 Compare November 8, 2024 09:19
@spikecurtis spikecurtis merged commit e5661c2 into main Nov 8, 2024
27 checks passed
@spikecurtis Graphite App
Copy link
Contributor Author

Merge activity

  • Nov 8, 4:32 AM EST: A user merged this pull request with Graphite.

@spikecurtis spikecurtis deleted the spike/14729-tunnel-src-ctrl branch November 8, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhance tailnetAPIConnector to support multiple peers
2 participants
@spikecurtis @ethanndickson