Skip to content

chore: improve PR deployments #15430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 11, 2024
Merged

chore: improve PR deployments #15430

merged 12 commits into from
Nov 11, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Nov 7, 2024

  • create a GitHub user for the GitHub actor

matifali and others added 3 commits November 6, 2024 22:57
@matifali
Update pr-deploy.yaml
97f616d
@matifali
chore: improve PR deployments
4b2e915 
- Correct user creation command with proper formatting.
- Update Slack notification condition for deployment actions.
@matifali
chore: improve PR deployments
9eaf130 
- Correct user creation command with proper formatting.
- Update Slack notification condition for deployment actions.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

✔️ PR 15430 Updated successfully.
🚀 Access the credentials here.

cc: @matifali

@matifali
chore: update actionlint version in CI workflow
1a6ec33
@matifali
fix(workflow): correct kube config permissions and reorder steps
93c8303 
Change kube config file permission to 600 for better security and reorder
the template and workspace creation steps to after user promotion.
@matifali
Separate user creation from deployments
8a146ca
@matifali matifali marked this pull request as draft November 7, 2024 18:18
@matifali matifali force-pushed the atif/pr-deployment branch 4 times, most recently from 5a180ec to b5d6efe Compare November 7, 2024 19:41
@matifali
Fix pr-deploy user creation and role setup
92c06b2 
- Correct user creation command with proper formatting.
- Update user role promotion to use `organization-admin`.
matifali and others added 4 commits November 11, 2024 00:32
@matifali
Merge branch 'main' into atif/pr-deployment
788d23a
@matifali
debug
dd00be0
@matifali
Improve PR deployment user and debug setup
c127969 
- Use public email if available for user creation, else default.
- Ensure `GH_TOKEN` is set for the workflow.
- Move tmate debug session to trigger only on failure.
@matifali
Remove tmate session from PR deploy workflow
d454ebd
@matifali matifali marked this pull request as ready for review November 11, 2024 10:56
cdr-bot[bot]
cdr-bot bot approved these changes Nov 11, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@matifali matifali merged commit 329e086 into main Nov 11, 2024
27 of 29 checks passed
@matifali matifali deleted the atif/pr-deployment branch November 11, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matifali