feat(cli): rotate file logs for coderd #15438
Conversation
| } | ||
| closers = append(closers, fi.Close) | ||
| sinks = append(sinks, sinkFn(fi)) | ||
| closers = append(closers, logWriter.Close) |
There was a problem hiding this comment.
Does this give us the equivalent behaviour of lumberjackWriteCloseFixer in cli/agent.go?
There was a problem hiding this comment.
I think we should probably re-use that same fix here, although the main reason for that seems to have been to reduce CI flakes due to racy writes after close. We probably won't be logging to a file in CI in the general case.
Agreed on a test; I was thinking about this over the weekend. |
There was a problem hiding this comment.
I smoke-tested this locally and noted our existing test coverage in TestServer/Logging.*. Testing Lumberjack's rotation is probably way too much overhead here.
If we wanted to add a test, we could extract addSinkIfNotProvided() in cli/clilog and test that on its own.
I trust your judgment. I'm happy to merge as-is. |
Related to #15309
As we already are doing for agent logs - this PR is enabling the logs rotation for coderd logs.
Currently keeping the same logic than we had for agent - with 5MB as the file size for rotation.