-
Notifications
You must be signed in to change notification settings - Fork 976
feat(coderd): update endpoint to allow filtering provisioner daemons by tags #15448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
3d45f55
feat(coderd/database): allow filtering provisioner daemons by tags
SasSwart 92b9d25
feat(coderd/database): allow filtering provisioner daemons by tags
SasSwart e68a8fc
add a type hint for sqlc
SasSwart 93058e6
ensure BC with GetProvisionerDaemonsByOrganization
SasSwart a2bfae3
add a type hint for sqlc
SasSwart 39ab8a0
fix unit test
SasSwart 8bf79c8
Add tags param to provisioner daemons endpoint
SasSwart 86f7dab
fix provisioner tag filtering
SasSwart bd6f3ed
handle tag reading error
SasSwart a2476dc
remove assignment to a nil map
SasSwart e835326
filter by tags in dbmem
SasSwart 23bd23f
correctly set the default value when no tags are provided
SasSwart 9985ef6
support the zero value tag in sql
SasSwart a173bfb
update the default value for when no tags are provided
SasSwart 70c7ea9
use a sql domain as a type alias so that we can override it as a Stri…
SasSwart 1c57bd2
complete down migration
SasSwart ebb716d
complete down migration
SasSwart 96b64f4
update the default value for when no tags are provided
SasSwart 5941dc3
fix job acquisition for untagged provisioners
SasSwart ff75f5e
make gen
SasSwart 85b1ef4
review notes
SasSwart 071fdc4
fix down migration
SasSwart 78abf67
use the correct name for provisionerdaemons' tag field
SasSwart d1c7d3e
typo
SasSwart 38d77cf
use the updated tag name
SasSwart 1c64353
fix special case of tagset_contains
SasSwart 8508cd8
Use a stringmap instead of a stringslice for provisioner tags
SasSwart 9dcbb83
update tags param parsing in provisionerDaemons
SasSwart 4c1fc0d
update tags param parsing in provisionerDaemons
SasSwart fbd70f3
fix special case of tagset_contains
SasSwart 69126f4
rename tagset_contains function
SasSwart e109caf
attempt to fix the special case for provisioner_tagset_contains
SasSwart f10561e
attempt to fix the special case for provisioner_tagset_contains
SasSwart a56b130
attempt to fix the special case for provisioner_tagset_contains
SasSwart 2bce007
fix provisioner_tagset_contains
SasSwart 2860f5d
remove defunct code
SasSwart d6f26df
Add tag filtering tests for GetProvisionerDaemons
SasSwart 1ce410f
fix foreign key constraint in tests
SasSwart c065742
Add linting
SasSwart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove assignment to a nil map
- Loading branch information
commit a2476dc5b02a94b703eb54cda4e420de1322d161
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.