Skip to content

examples/docker-local: add explanatory comment #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

examples/docker-local: add explanatory comment #1545

merged 1 commit into from
May 18, 2022

Conversation

johnstcn
Copy link
Member

Adds a comment to the docker-local example template regarding coder.url and pointing users to edit the URL to their environment.

@johnstcn johnstcn self-assigned this May 18, 2022
bpmct
bpmct approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way we could programmatically detect this, but this makes sense and I imagine it'd work in most cases. 👍🏼

The sucky thing about running docker-compose locally is the docker example is the only one that works.

@johnstcn johnstcn merged commit 13571b0 into main May 18, 2022
@johnstcn johnstcn deleted the cj/docker-local-doc branch May 18, 2022 16:10
@coadler
Copy link
Contributor

coadler commented May 18, 2022 •
edited
Loading

cc @johnstcn @bpmct Can we have a docker-compose specific template? docker-local used to work just fine without coderd being run in docker-compose and this sort of broke my workflow, and seems like an odd default.

@johnstcn
Copy link
Member Author

@coadler we could instead set the access URL of coder to https://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

@coadler
Copy link
Contributor

coadler commented May 18, 2022

@coadler we could instead set the access URL of coder to https://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

I think that seems reasonable too!

@bpmct
Copy link
Member

bpmct commented May 18, 2022

@coadler we could instead set the access URL of coder to https://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

I agree we should do this instead.

This was referenced May 19, 2022
Merged
Merged
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@johnstcn @kylecarbs
examples/docker-local: add explanatory comment (#1545)
668e448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@bpmct bpmct bpmct approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnstcn @coadler @bpmct @kylecarbs