Skip to content

chore: use hsl for tailwind and shadcn theming #15453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Nov 8, 2024
@BrunoQuaresma BrunoQuaresma changed the title chore: uses hsl for tailwind and shadcn theming chore: use hsl for tailwind and shadcn theming Nov 8, 2024
@@ -8,7 +8,8 @@ module.exports = {
important: ["#root", "#storybook-root"],
theme: {
fontSize: {
"2xs": ["0.626rem","0.875rem"],
"2xs": ["0.626rem", "0.875rem"],
xs: ["0.75rem", "1rem"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"0.75rem", "1rem" is already the Tailwind default for xs so this should not be necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't working until I added it. Can you test it on your end to double-check?

@jaaydenh
Copy link
Contributor

jaaydenh commented Nov 8, 2024

@BrunoQuaresma just to confirm since there is no description. HSL is needed to get the alpha for colors to work correctly?

@BrunoQuaresma
Copy link
Collaborator Author

@BrunoQuaresma just to confirm since there is no description. HSL is needed to get the alpha for colors to work correctly?

My bad 🙏 You are correct!

@jaaydenh
Copy link
Contributor

jaaydenh commented Nov 8, 2024

@BrunoQuaresma I originally made a mistake putting fontSize under theme instead of theme->extend. the former overwrites all the existing fontSize classes. I moved this to extend so it only overrides what is explicitly added in the config. So text-sm should work correctly now.

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrunoQuaresma BrunoQuaresma merged commit 308df17 into main Nov 8, 2024
27 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/use-hsl-tailwind branch November 8, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants