Skip to content

fix: standardize height between dropdown menu buttons #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2022

Conversation

Kira-Pilot
Copy link
Member

resolves #1229

There was a little bit of height diff between the menus, thus the chromatic snapshots have changed slightly. The overall height of the menu (42px) remains the same.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner May 18, 2022 12:33
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It'd be awesome if we adjusted the title to be something more indicative of the fix, we use these titles as a changelog. Here's an example: https://github.com/coder/coder/releases/tag/v0.5.10

@Kira-Pilot Kira-Pilot changed the title User tray margin/kira pilot fix: standardize height between dropdown menu buttons May 18, 2022
@Kira-Pilot Kira-Pilot merged commit 85a932b into main May 18, 2022
@Kira-Pilot Kira-Pilot deleted the user-tray-margin/kira-pilot branch May 18, 2022 14:34
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: User Tray needs margin
3 participants