fix(coderd): ensure correct RBAC when enqueueing notifications #15478
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. review: moved to its own package to avoid import cycle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package notificationstest | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "sync" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
|
|
||
| "github.com/coder/coder/v2/coderd/database/dbauthz" | ||
| "github.com/coder/coder/v2/coderd/rbac" | ||
| "github.com/coder/coder/v2/coderd/rbac/policy" | ||
| ) | ||
|
|
||
| type FakeEnqueuer struct { | ||
| authorizer rbac.Authorizer | ||
| mu sync.Mutex | ||
| sent []*FakeNotification | ||
| } | ||
|
|
||
| type FakeNotification struct { | ||
| UserID, TemplateID uuid.UUID | ||
| Labels map[string]string | ||
| Data map[string]any | ||
| CreatedBy string | ||
| Targets []uuid.UUID | ||
| } | ||
|
|
||
| // TODO: replace this with actual calls to dbauthz. | ||
| // See: https://github.com/coder/coder/issues/15481 | ||
| func (f *FakeEnqueuer) assertRBACNoLock(ctx context.Context) { | ||
dannykopping marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if f.mu.TryLock() { | ||
| panic("Developer error: do not call assertRBACNoLock outside of a mutex lock!") | ||
| } | ||
|
|
||
| // If we get here, we are locked. | ||
| if f.authorizer == nil { | ||
| f.authorizer = rbac.NewStrictCachingAuthorizer(prometheus.NewRegistry()) | ||
| } | ||
|
|
||
| act, ok := dbauthz.ActorFromContext(ctx) | ||
| if !ok { | ||
| panic("Developer error: no actor in context, you may need to use dbauthz.AsNotifier(ctx)") | ||
| } | ||
|
|
||
| for _, a := range []policy.Action{policy.ActionCreate, policy.ActionRead} { | ||
| err := f.authorizer.Authorize(ctx, act, a, rbac.ResourceNotificationMessage) | ||
| if err == nil { | ||
| return | ||
| } | ||
|
|
||
| if rbac.IsUnauthorizedError(err) { | ||
| panic(fmt.Sprintf("Developer error: not authorized to %s %s. "+ | ||
| "Ensure that you are using dbauthz.AsXXX with an actor that has "+ | ||
| "policy.ActionCreate on rbac.ResourceNotificationMessage", a, rbac.ResourceNotificationMessage.Type)) | ||
| } | ||
| panic("Developer error: failed to check auth:" + err.Error()) | ||
| } | ||
| } | ||
|
|
||
| func (f *FakeEnqueuer) Enqueue(ctx context.Context, userID, templateID uuid.UUID, labels map[string]string, createdBy string, targets ...uuid.UUID) (*uuid.UUID, error) { | ||
| return f.EnqueueWithData(ctx, userID, templateID, labels, nil, createdBy, targets...) | ||
| } | ||
|
|
||
| func (f *FakeEnqueuer) EnqueueWithData(ctx context.Context, userID, templateID uuid.UUID, labels map[string]string, data map[string]any, createdBy string, targets ...uuid.UUID) (*uuid.UUID, error) { | ||
| return f.enqueueWithDataLock(ctx, userID, templateID, labels, data, createdBy, targets...) | ||
| } | ||
|
|
||
| func (f *FakeEnqueuer) enqueueWithDataLock(ctx context.Context, userID, templateID uuid.UUID, labels map[string]string, data map[string]any, createdBy string, targets ...uuid.UUID) (*uuid.UUID, error) { | ||
| f.mu.Lock() | ||
| defer f.mu.Unlock() | ||
| f.assertRBACNoLock(ctx) | ||
|
|
||
| f.sent = append(f.sent, &FakeNotification{ | ||
| UserID: userID, | ||
| TemplateID: templateID, | ||
| Labels: labels, | ||
| Data: data, | ||
| CreatedBy: createdBy, | ||
| Targets: targets, | ||
| }) | ||
|
|
||
| id := uuid.New() | ||
dannykopping marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return &id, nil | ||
| } | ||
|
|
||
| func (f *FakeEnqueuer) Clear() { | ||
| f.mu.Lock() | ||
| defer f.mu.Unlock() | ||
|
|
||
| f.sent = nil | ||
| } | ||
|
|
||
| func (f *FakeEnqueuer) Sent() []*FakeNotification { | ||
| f.mu.Lock() | ||
| defer f.mu.Unlock() | ||
| return append([]*FakeNotification{}, f.sent...) | ||
mtojek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review: no changes are needed to
lifecycle_executor.goas it has its own actor to which I've added the required permissions