Skip to content

feat: Add SSH agent forwarding support to coder agent #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 25, 2022
Merged

feat: Add SSH agent forwarding support to coder agent #1548

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54b74f7
feat: Add SSH agent forwarding support to coder agent
mafredri May 18, 2022
3df1a08
feat: Add forward agent flag to `coder ssh`
mafredri May 24, 2022
51c4128
refactor: Share setup between SSH tests, sync goroutines
mafredri May 24, 2022
8f0d454
feat: Add test for `coder ssh --forward-agent`
mafredri May 24, 2022
ce9c05d
fix: Fix TestSSH/ImmediateExit flakyness with sleep
mafredri May 24, 2022
f1596de
fix: Fix ForwardAgent test on macOS
mafredri May 24, 2022
5044d11
fix: Fix test flakes and implement Deans suggestion for helpers
mafredri May 24, 2022
e754672
fix: Add example to config-ssh
mafredri May 24, 2022
8d3df94
fix: Ignore closed errors in test
mafredri May 24, 2022
ea46d7b
fix: Allow forwarding agent via -A
mafredri May 24, 2022
326b942
Update cli/ssh_test.go
mafredri May 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fix ForwardAgent test on macOS
  • Loading branch information
@mafredri
mafredri committed May 24, 2022
commit f1596de59cc4b0a3ab3fdc62a93da5fe80e004c9
6 changes: 4 additions & 2 deletions cli/ssh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,15 +211,17 @@ func TestSSH(t *testing.T) {
})

// Ensure that SSH_AUTH_SOCK is set.
// Linux: /tmp/auth-agent3167016167/listener.sock
// macOS: /var/folders/ng/m1q0wft14hj0t3rtjxrdnzsr0000gn/T/auth-agent3245553419/listener.sock
pty.WriteLine("env")
pty.ExpectMatch("SSH_AUTH_SOCK=/tmp") // E.g. /tmp/auth-agent3167016167/listener.sock
pty.ExpectMatch("SSH_AUTH_SOCK=")
// Ensure that ssh-add lists our key.
pty.WriteLine("ssh-add -L")
keys, err := kr.List()
require.NoError(t, err)
pty.ExpectMatch(keys[0].String())

// kthxbye
// And we're done.
pty.WriteLine("exit")
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: This is such a cool test.

}
Expand Down