Skip to content

feat: add total users insight #15486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

feat: add total users insight #15486

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a20be9f
feat: add registered users insights
BrunoQuaresma Nov 12, 2024
4e43cc0
Merge branch 'main' of https://github.com/coder/coder into bq/add-reg…
BrunoQuaresma Nov 12, 2024
24baca9
Add tests
BrunoQuaresma Nov 12, 2024
da5f1b8
Fix make gen
BrunoQuaresma Nov 12, 2024
e77cf67
Fix query
BrunoQuaresma Nov 13, 2024
7cd2d86
Fix in memory repro
BrunoQuaresma Nov 13, 2024
442c75a
Fix policy
BrunoQuaresma Nov 13, 2024
bcf91f9
Fix roles test
BrunoQuaresma Nov 13, 2024
70e66a8
Fix dbauthz test
BrunoQuaresma Nov 13, 2024
3da408e
Fix dbauthz test 2
BrunoQuaresma Nov 13, 2024
639777f
Fix return at dbauthz
BrunoQuaresma Nov 13, 2024
520790d
Fix args
BrunoQuaresma Nov 13, 2024
c011a05
Gen golden files
BrunoQuaresma Nov 13, 2024
eaac6c1
Merge branch 'main' of https://github.com/coder/coder into bq/add-reg…
BrunoQuaresma Nov 14, 2024
0e94c74
Pass the zone into the query
BrunoQuaresma Nov 14, 2024
186a951
Fix tests
BrunoQuaresma Nov 14, 2024
d340e2d
Use offset instead of zone
BrunoQuaresma Nov 14, 2024
82b6c36
Fix offset to str
BrunoQuaresma Nov 14, 2024
81c8038
Merge branch 'main' of https://github.com/coder/coder into bq/add-reg…
BrunoQuaresma Nov 22, 2024
fac0c68
Fix tests with expected value correctly
BrunoQuaresma Nov 22, 2024
9ba203c
Remove GetAccumulatedUsersInsights for now
SasSwart Nov 26, 2024
a85e3f9
Merge remote-tracking branch 'origin/main' into bq/add-registered-use…
SasSwart Nov 26, 2024
6fb880c
Remove temporarily defunct sdk functions
SasSwart Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 14, 2024
commit 186a95127dde0dfb97970c69bb8833d76ac89a96
26 changes: 17 additions & 9 deletions coderd/insights_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2380,11 +2380,17 @@ func TestTotalUsersInsight(t *testing.T) {
Username: "user3",
CreatedAt: daysAgo(1),
})
dbgen.User(t, db, database.User{
Email: "user4@coder.com",
Username: "user4",
CreatedAt: daysAgo(0),
})

// When: requesting the accumulated total of users by day
now := time.Now().UTC().Truncate(time.Hour).Add(time.Hour)
res, err := client.TotalUsersInsight(ctx, codersdk.TotalUsersInsightRequest{
StartTime: daysAgo(2),
EndTime: today(),
EndTime: now,
})
require.NoError(t, err)

Expand All @@ -2400,7 +2406,7 @@ func TestTotalUsersInsight(t *testing.T) {
require.Equal(t, res[1].Total, uint64(3))

// Third day
require.Equal(t, res[2].Date, today().Format(time.DateOnly))
require.Equal(t, res[2].Date, daysAgo(0).Format(time.DateOnly))
require.Equal(t, res[2].Total, uint64(4))
})

Expand All @@ -2417,11 +2423,17 @@ func TestTotalUsersInsight(t *testing.T) {
Username: "user1",
CreatedAt: daysAgo(2),
})
dbgen.User(t, db, database.User{
Email: "user2@coder.com",
Username: "user2",
CreatedAt: daysAgo(1),
})

// When: requesting the accumulated total of users for dates with no users created
now := time.Now().UTC().Truncate(time.Hour).Add(time.Hour)
res, err := client.TotalUsersInsight(ctx, codersdk.TotalUsersInsightRequest{
StartTime: daysAgo(2).Truncate(24 * time.Hour),
EndTime: today(),
EndTime: now,
})
require.NoError(t, err)

Expand All @@ -2434,18 +2446,14 @@ func TestTotalUsersInsight(t *testing.T) {

// Second day - no users created so should contain the same total as the previous day
require.Equal(t, res[1].Date, daysAgo(1).Format(time.DateOnly))
require.Equal(t, res[1].Total, uint64(1))
require.Equal(t, res[1].Total, uint64(2))

// Third day
require.Equal(t, res[2].Date, today().Format(time.DateOnly))
require.Equal(t, res[2].Date, daysAgo(0).Format(time.DateOnly))
require.Equal(t, res[2].Total, uint64(2))
})
}

func daysAgo(days int) time.Time {
return time.Now().UTC().AddDate(0, 0, -days).Truncate(24 * time.Hour)
}

func today() time.Time {
return time.Now().UTC().Truncate(time.Hour).Add(time.Hour)
}
Loading