ci: reenable link checker & fix broken links #15489
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
docs/admin/users/idp-sync.md
Outdated
| @@ -327,8 +327,7 @@ the OIDC provider. See | |||
| > ones include `groups`, `memberOf`, and `roles`. | |||
|
|
|||
| Next configure the Coder server to read groups from the claim name with the | |||
| [OIDC organization field](../../reference/cli/server.md#--oidc-organization-field) | |||
| server flag: | |||
| OIDC organization field server flag: | |||
There was a problem hiding this comment.
This CLI arg got moved to runtime config a few days ago, so it's no longer in the reference. The docs will need updating soon.
2777501 to
4fd8bb0
Compare
| @@ -1,9 +1,19 @@ | |||
| dirs: | |||
| - docs | |||
| excludedDirs: | |||
| # Downstream bug in linkspector means large markdown files fail to parse | |||
| # but these are autogenerated and shouldn't need checking | |||
There was a problem hiding this comment.
See failed CI run: https://github.com/coder/coder/actions/runs/11797850940/job/32862729001?pr=15482
https://github.com/micromark/micromark/blob/dd1bbe0c80fe4c4d1e3ee7adeaff1d8e81e3818f/packages/micromark-util-subtokenize/dev/lib/splice-buffer.js#L121-L123
https://stackoverflow.com/questions/22123769/rangeerror-maximum-call-stack-size-exceeded-why
4fd8bb0 to
4ae52ed
Compare
| @@ -33,6 +33,7 @@ jobs: | |||
| reporter: github-pr-review | |||
| config_file: ".github/.linkspector.yml" | |||
| fail_on_error: "true" | |||
| filter_mode: "nofilter" | |||
There was a problem hiding this comment.
I incorrectly assumed that the weekly-docs job being started from the cron job would mean it wouldn't use the pull request changes filter, but evidently not. This means it checks the whole docs folder for the cron job & on PRs. It complained about the emacs link on this PR, even though it wasn't included in the diff, so I'm more confident that it works properly now.
There was a problem hiding this comment.
So on schedule, we check the whole repo?
What does the filter_mode mean?
There was a problem hiding this comment.
The default filter_mode was just the PR diff. Now it should be everything mentioned in the .linkspector.yml config.
Follow-up on #15484.