-
Notifications
You must be signed in to change notification settings - Fork 923
ci: reenable link checker & fix broken links #15489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,22 @@ | ||
dirs: | ||
- docs | ||
excludedDirs: | ||
# Downstream bug in linkspector means large markdown files fail to parse | ||
# but these are autogenerated and shouldn't need checking | ||
- docs/reference | ||
# Older changelogs may contain broken links | ||
- docs/changelogs | ||
ignorePatterns: | ||
- pattern: "://localhost" | ||
- pattern: '://.*.?example\\.com' | ||
- pattern: "github.com/<your_github_handle>" | ||
- pattern: "localhost" | ||
- pattern: "example.com" | ||
- pattern: "mailto:" | ||
- pattern: "127.0.0.1" | ||
- pattern: "0.0.0.0" | ||
- pattern: "JFROG_URL" | ||
- pattern: "coder.company.org" | ||
# These real sites were blocking the linkspector action / GitHub runner IPs(?) | ||
- pattern: "i.imgur.com" | ||
- pattern: "code.visualstudio.com" | ||
- pattern: "www.emacswiki.org" | ||
aliveStatusCodes: | ||
- 200 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ on: | |
schedule: | ||
- cron: "0 9 * * 1" | ||
workflow_dispatch: # allows to run manually for testing | ||
# pull_request: | ||
# branches: | ||
# - main | ||
# paths: | ||
# - "docs/**" | ||
pull_request: | ||
branches: | ||
- main | ||
paths: | ||
- "docs/**" | ||
|
||
permissions: | ||
contents: read | ||
|
@@ -33,6 +33,7 @@ jobs: | |
reporter: github-pr-review | ||
config_file: ".github/.linkspector.yml" | ||
fail_on_error: "true" | ||
filter_mode: "nofilter" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I incorrectly assumed that the weekly-docs job being started from the cron job would mean it wouldn't use the pull request changes filter, but evidently not. This means it checks the whole There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So on schedule, we check the whole repo? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default filter_mode was just the PR diff. Now it should be everything mentioned in the |
||
|
||
- name: Send Slack notification | ||
if: failure() && github.event_name == 'schedule' | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See failed CI run: https://github.com/coder/coder/actions/runs/11797850940/job/32862729001?pr=15482
https://github.com/micromark/micromark/blob/dd1bbe0c80fe4c4d1e3ee7adeaff1d8e81e3818f/packages/micromark-util-subtokenize/dev/lib/splice-buffer.js#L121-L123
https://stackoverflow.com/questions/22123769/rangeerror-maximum-call-stack-size-exceeded-why