Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implement CRUD UI for IDP organization sync settings #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement CRUD UI for IDP organization sync settings #15503
Changes from 1 commit
d0baa8c
6463076
f714986
072d775
f6e286c
acf8cbe
ad1aa84
b01588d
6203d04
bc37998
2c2246d
6971f91
6e87130
a1b6e79
36c8706
a4e66c2
f7be49f
90a65fe
c282765
40155bc
a129820
8edd4b4
e54e5ca
bb16bd1
678a91d
a13d9b2
1b8efd1
137c25c
46a4646
85a455c
a9e06f1
d921b08
ba665b4
8a0e789
234c0fb
7d88a38
c6c9b16
5322a4e
eab8a0d
721d5d4
8986cbd
89a7b12
148dca7
0c338b0
0cadc8b
1d7153b
a914c54
bd307c0
95bfd17
82bd850
6eb6987
3822b2e
fe17b1c
e75e179
c6e07ff
a3b9b27
0601164
b01e5d3
1c5b6ef
6e2ee08
ae30db0
ac74cdc
a99dca5
4c00959
568a5a9
c313439
506223d
f223ab7
94ff4ca
9101e0e
5ca2c0c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to be honest: I spun up the UI, and I don't fully understand how to use it, or how to evaluate whether the user flows make sense.
I'm just going to be writing questions/comments that come to mind while I'm testing things out. Feel free to pick and choose which feedback actually makes sense:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation hasn't been created yet and some of the things you are mentioning, especially editing rows in the table are intended to be updated in a future PR. I also wanted to leave the table as is, since this would get replaced with a non-MUI table in the future with the work for IDP group and role sync.
When clicking the switch, a toast does appear telling the user the settings have been updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my thinking with UI is that it should be as obvious to the user before they even interact with it. As in, it should set relatively firm expectations on what something does, so that the user can confidently decide if the element is even relevant to them
If the user has to interact with the element once to know exactly what it does, I feel like there's something that can be done to make the UI more clear. UI engineering wants to minimize surprises
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Parkreiner I think this may be a good discussion for FE Variety. Right now, the assumption is that a user would probably not interact with this page without reading the docs first. Historically, I believe these kings of settings would be handled with an onboarding call. Of course its a great goal for a user to intuitively understand everything about a page just by looking at it but there will be tradeoffs in usability and design esthetics. For example, the atomic saving of each element of the form was a tradeoff, the alternative design with a single save button for the entire form, considered that if the table had many rows, the save button for the entire form would be pushed below the fold, so that an indicator would be needed to let the user know the form is dirty. Is possible this is a better design, but doing the work iteratively will allow more people to use it and to get some feedback about what works and doesn't work.