fix: remove built-in image for Docker template #15504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
approved these changes
Nov 14, 2024
|
I am ok to switch to a more universal kitchen sink image, only concern is that it will make the first boot slower for new users due to image size. |
|
Gotcha. i am going to merge this for now, and when we make a better image in |
ethanndickson
added a commit
that referenced
this pull request
Nov 14, 2024
- #15504 broke CI on main because of the aforementioned issue, this also fixes the test failure.
This was referenced Jan 18, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded image is an anti-pattern, leading to weird errors if the
dockergroup is absent. We should either provide a better error in-product or just have a better image.@matifali - also down to use a Devcontainers universal image instead or make this a parameter. Let me know what you think the best "default install" is