Skip to content

feat(coderd): add endpoint to fetch provisioner key details #15505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 20, 2024
Merged

feat(coderd): add endpoint to fetch provisioner key details #15505

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
995a046
feat(provisioners) - add endpoint to fetch tags associated to a key u…
defelmnq Nov 14, 2024
2ca6c91
rename function
defelmnq Nov 14, 2024
c67d322
linter
defelmnq Nov 14, 2024
911a47d
linter
defelmnq Nov 14, 2024
1a019bb
generate doc
defelmnq Nov 14, 2024
c629f07
changes endpoint to return all pk details
defelmnq Nov 18, 2024
54437f2
generate doc
defelmnq Nov 18, 2024
8eeffb1
work on tests
defelmnq Nov 18, 2024
960084d
Merge remote-tracking branch 'origin/main' into api-endpoint-provisio…
defelmnq Nov 19, 2024
4a38977
improve testing strategy and errors handling
defelmnq Nov 19, 2024
c89bcd8
add missing tests
defelmnq Nov 20, 2024
0af9e8e
work on tests
defelmnq Nov 20, 2024
4680484
improved test logic
defelmnq Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add missing tests
  • Loading branch information
@defelmnq
defelmnq committed Nov 20, 2024
commit c89bcd8927a114517a16d235d4bad22f40c48a0e
14 changes: 14 additions & 0 deletions enterprise/coderd/provisionerkeys_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,20 @@
success: true,
expectedErr: "",
},
{
name: "using unknown key",
useFakeKey: true,
fakeKey: "unknownKey",
success: false,
expectedErr: "provisioner daemon key invalid",
},
{
name: "no key provided",
useFakeKey: true,
fakeKey: "",
success: false,
expectedErr: "provisioner daemon key required",
},
}

for _, tt := range tests {
Expand All @@ -172,7 +186,7 @@
},
})

key, err := client.CreateProvisionerKey(ctx, owner.OrganizationID, codersdk.CreateProvisionerKeyRequest{

Check failure on line 189 in enterprise/coderd/provisionerkeys_test.go

View workflow job for this annotation

GitHub Actions / lint 

ruleguard: This client is operating as the owner user, which has unrestricted permissions. Consider creating a different user. (gocritic)
Name: "my-test-key",
Tags: map[string]string{"key1": "value1", "key2": "value2"},
})
Expand Down
Loading