Skip to content

feat(examples/templates/azure-windows): add azure region and windows-rdp modules #15516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat(examples/templates/azure-windows): add azure region and windows-rdp modules #15516

merged 2 commits into from
Jan 7, 2025

Conversation

phorcys420
Copy link
Member

@phorcys420 phorcys420 commented Nov 14, 2024 •
edited
Loading

This PR removes the coder_parameter definition for the Azure region and uses the Azure region module.

Available at crazy_lehmann9 version of the azure-windows template.

  • Testing
    • Region selector works and workspace gets provisioned

@phorcys420 phorcys420 changed the title feat(example/templates/azure-windows): use azure region module feat(examples/templates/azure-windows): use azure region module Nov 16, 2024
@phorcys420
Copy link
Member Author

Currently unable to test since the dogfood instance doesn't have the az CLI, I think we should edit this template to not use local-exec in the first place.

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 24, 2024
@github-actions github-actions bot closed this Nov 28, 2024
@phorcys420 phorcys420 reopened this Jan 7, 2025
@phorcys420 phorcys420 force-pushed the promote-modules-azure-windows branch from 49eb214 to 396855f Compare January 7, 2025 18:03
@phorcys420 phorcys420 changed the title feat(examples/templates/azure-windows): use azure region module feat(examples/templates/azure-windows): add azure region and windows-rdp modules Jan 7, 2025
@phorcys420 phorcys420 removed the stale This issue is like stale bread. label Jan 7, 2025
@phorcys420 phorcys420 marked this pull request as ready for review January 7, 2025 18:27
@phorcys420
Copy link
Member Author

Works as intended, available on dogfood @ https://dev.coder.com/templates/coder/azure-windows/versions/phorcys-debug-15176

image

matifali
matifali approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@matifali matifali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phorcys420.

@phorcys420 phorcys420 enabled auto-merge (squash) January 7, 2025 18:29
@phorcys420 phorcys420 merged commit 8fb7832 into main Jan 7, 2025
29 checks passed
@phorcys420 phorcys420 deleted the promote-modules-azure-windows branch January 7, 2025 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@phorcys420 phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phorcys420 @matifali