Skip to content

feat(examples/templates/azure-linux): promote module usage #15517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

feat(examples/templates/azure-linux): promote module usage #15517

merged 2 commits into from
Nov 18, 2024

Conversation

phorcys420
Copy link
Member

@phorcys420 phorcys420 commented Nov 14, 2024 •
edited
Loading

This PR:

  • removes the coder_parameter definition for the Azure region and uses the Azure region module.
  • uses modules for code-server and JetBrains Gateway

Available at promote-modules-pr-20420 version of the azure-linux template.

  • Testing
    • Region selector works and workspace gets provisioned
    • code-server works
    • JetBrains Gateway works

@phorcys420 phorcys420 marked this pull request as ready for review November 16, 2024 21:57
@phorcys420 phorcys420 enabled auto-merge (squash) November 16, 2024 21:58
matifali
matifali approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @phorcys420.

@phorcys420 phorcys420 merged commit f9d6698 into main Nov 18, 2024
29 checks passed
@phorcys420 phorcys420 deleted the promote-modules-azure-linux branch November 18, 2024 08:40
johnstcn
johnstcn reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn left review comments

@matifali matifali matifali approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@phorcys420 phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phorcys420 @johnstcn @matifali