Skip to content

feat(provisionersdk): allow variadic tags in provisionersdk.MutateTags #15518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

johnstcn
Copy link
Member

Relates to #15087 and #15427

Allows specifying multiple sets of provisioner tags into MutateTags. These tags get additively merged.

This will simplify handling tags from multiple sources when sniffing tags from the template.

@johnstcn johnstcn self-assigned this Nov 14, 2024
@SasSwart
Copy link
Contributor

Just saw this. Sorry for the delay :). Will look into it soon.

Copy link
Contributor

@SasSwart SasSwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johnstcn johnstcn requested a review from mtojek November 15, 2024 12:27
@johnstcn johnstcn merged commit aca5be5 into main Nov 15, 2024
26 checks passed
@johnstcn johnstcn deleted the cj/15087-provisionertags-mutate-variadic branch November 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants